Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump PyT to 25.01 #11973

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

build: Bump PyT to 25.01 #11973

wants to merge 31 commits into from

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jan 28, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Contributor

github-actions bot commented Feb 4, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g removed the Run CICD label Feb 7, 2025
@github-actions github-actions bot added the CI label Feb 7, 2025
@ko3n1g ko3n1g removed the CI label Feb 7, 2025
@chtruong814 chtruong814 force-pushed the ko3n1g/build/bump-pyt-25.01 branch from 7ecaf9b to 538a0d6 Compare February 11, 2025 21:23
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 12, 2025
dimapihtar and others added 6 commits February 13, 2025 07:31
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
hemildesai and others added 2 commits February 14, 2025 02:17
* Fix nsys callback tests

Signed-off-by: Hemil Desai <[email protected]>

* Simplify tests

Signed-off-by: Hemil Desai <[email protected]>

* Fix

Signed-off-by: Hemil Desai <[email protected]>

---------

Signed-off-by: Hemil Desai <[email protected]>
* fix attention impl config

Signed-off-by: Maanu Grover <[email protected]>

* safeguard against empty key added by mcore

Signed-off-by: Maanu Grover <[email protected]>

* docu

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* noqa?

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* noqa?

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* remove unused import

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

---------

Signed-off-by: Maanu Grover <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Co-authored-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
@github-actions github-actions bot added the core Changes to NeMo Core label Feb 14, 2025
chtruong814 and others added 2 commits February 14, 2025 17:20
…12175)

* Use pip --no-deps --force-reinstall when building the test container

Signed-off-by: Charlie Truong <[email protected]>

* Explicitly reinstall nvidia-resiliency

Signed-off-by: Charlie Truong <[email protected]>

* Do not have pytest capture output in lightning unit tests

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
…#12198)

* Set weights_only=False in torch.load within EMA callbck

Signed-off-by: Charlie Truong <[email protected]>

* Set weights_only=False in torch.load call in adapter_mixins

Signed-off-by: Charlie Truong <[email protected]>

* Apply isort and black reformatting

Signed-off-by: chtruong814 <[email protected]>

* Fix lint errors in ema and adapter_mixins

Signed-off-by: Charlie Truong <[email protected]>

* Apply isort and black reformatting

Signed-off-by: chtruong814 <[email protected]>

* Fix undefined name error in adapter_mixins

Signed-off-by: Charlie Truong <[email protected]>

* Apply isort and black reformatting

Signed-off-by: chtruong814 <[email protected]>

* Remove unnecessary import of __futures__ in adapter_mixins

Signed-off-by: Charlie Truong <[email protected]>

* Fix more locations where weights_only=False needs to be passed to torch.load

Signed-off-by: Charlie Truong <[email protected]>

* Fix lint issues in nemo_model_checkpoint

Signed-off-by: Charlie Truong <[email protected]>

* Apply isort and black reformatting

Signed-off-by: chtruong814 <[email protected]>

* Correct noqa F821 line in nemo_model_checkpoint

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: chtruong814 <[email protected]>
Co-authored-by: chtruong814 <[email protected]>
maanug-nv and others added 5 commits February 14, 2025 20:00
* Use pip --no-deps --force-reinstall when building the test container

Signed-off-by: Charlie Truong <[email protected]>

* Explicitly reinstall nvidia-resiliency

Signed-off-by: Charlie Truong <[email protected]>

* Do not have pytest capture output in lightning unit tests

Signed-off-by: Charlie Truong <[email protected]>

* mock invoke context

Signed-off-by: Maanu Grover <[email protected]>

* Revert "Do not have pytest capture output in lightning unit tests"

This reverts commit 162c730.

Signed-off-by: Maanu Grover <[email protected]>

* tweak

Signed-off-by: Maanu Grover <[email protected]>

* more patches needed

Signed-off-by: Maanu Grover <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Maanu Grover <[email protected]>
Co-authored-by: Charlie Truong <[email protected]>
…o ko3n1g/build/bump-pyt-25.01

Signed-off-by: Charlie Truong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants