Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the local path in Sortformer diarizer training tutorial #12135

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

tango4j
Copy link
Collaborator

@tango4j tango4j commented Feb 11, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fixes the local path in Sortformer diarizer training tutorial

Collection: ASR

Changelog

  • Removed all the local paths in End_to_End_Diarization_Training.ipynb

Usage

  • Run the following Jupyter notebook
    NeMo/tutorials/speaker_tasks/End_to_End_Diarization_Training.ipynb

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in NeMo ASR

tango4j and others added 30 commits December 20, 2024 16:50
Signed-off-by: Taejin Park <[email protected]>
Signed-off-by: Taejin Park <[email protected]>
Signed-off-by: Taejin Park <[email protected]>
Signed-off-by: Taejin Park <[email protected]>
Signed-off-by: Taejin Park <[email protected]>
@tango4j tango4j marked this pull request as draft February 11, 2025 10:56
@tango4j tango4j enabled auto-merge (squash) February 12, 2025 19:22
@ko3n1g
Copy link
Collaborator

ko3n1g commented Feb 12, 2025

⚠️ We have entered code-freeze. If this PR should be part of the 25.02 framework-release, please attach the label r2.2.0 before merging this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants