Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add err msg if download failed #12142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Open

Add err msg if download failed #12142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7640fd
Add err msg if download failed
yuanzhedong Feb 11, 2025
fc9f4e7
Apply isort and black reformatting
yuanzhedong Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nemo/collections/nlp/modules/common/megatron/megatron_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ def _download(path: str, url: str):
os.makedirs(MEGATRON_CACHE, exist_ok=True)
logging.info(f"Downloading from {url} to {path}")
downloaded_path = wget.download(url)
if not os.path.exists(downloaded_path):
raise FileNotFoundError(f"Download failed: {downloaded_path}")
shutil.move(downloaded_path, path)
# wait until the master process downloads the file and writes it to the cache dir
if torch.distributed.is_initialized():
Expand All @@ -230,12 +232,12 @@ def is_lower_cased_megatron(pretrained_model_name):

def get_megatron_tokenizer(pretrained_model_name: str):
"""
Takes a pretrained_model_name for megatron such as "megatron-bert-cased" and returns the according
Takes a pretrained_model_name for megatron such as "megatron-bert-cased" and returns the according
tokenizer name for tokenizer instantiating.

Args:
pretrained_model_name: pretrained_model_name for megatron such as "megatron-bert-cased"
Returns:
Returns:
tokenizer name for tokenizer instantiating
"""
_check_megatron_name(pretrained_model_name)
Expand Down
Loading