Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow store to be set for process group init #12461

Merged
merged 9 commits into from
Mar 11, 2025
Merged

Conversation

ananthsub
Copy link
Collaborator

@ananthsub ananthsub commented Mar 3, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

This change allows the torch.distributed Store to be an attribute of the strategy classes in Nemo. This allows users to customize the store used for the global process group creation before the trainer runs.

By default, the store argument in init_process_group is None (ref) so this PR introduces no functional changes.

init_process_group is not directly accessible or overrideable from the Lightning strategies.

I've copied the code from the superclasses (setup_distributed / setup_environment ) and the util function Lightning relies in order to be able to directly call this function and pass the store in.

TLDR:
All of these changes are so we can go from this:

torch.distributed.init_process_group(self._process_group_backend, rank=global_rank, world_size=world_size)

to this:

torch.distributed.init_process_group(self._process_group_backend, rank=global_rank, world_size=world_size, store=self.store)

The motivation for this PR is to make subsequent PRs integrating Nemo with in-process restart more focused.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@ananthsub ananthsub marked this pull request as ready for review March 5, 2025 16:52
@ananthsub ananthsub requested a review from maanug-nv March 5, 2025 23:33
maanug-nv
maanug-nv previously approved these changes Mar 7, 2025
maanug-nv
maanug-nv previously approved these changes Mar 7, 2025
Copy link
Collaborator

@maanug-nv maanug-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM.

ananthsub and others added 8 commits March 10, 2025 10:10
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
@ananthsub ananthsub merged commit 6036565 into NVIDIA:main Mar 11, 2025
193 checks passed
@ananthsub ananthsub deleted the add-store branch March 11, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants