Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support compilation against shared system libs #306

Open
5 of 8 tasks
runlevel5 opened this issue Aug 17, 2023 · 2 comments
Open
5 of 8 tasks

[Feature Request] Support compilation against shared system libs #306

runlevel5 opened this issue Aug 17, 2023 · 2 comments

Comments

@runlevel5
Copy link
Contributor

runlevel5 commented Aug 17, 2023

I could tell that Q2RTX has a list of bundled external dependencies residing in ./extern. Most of them are packaged and support by Ubuntu and Fedora. I would like to propose to add USE_SYSTEM_<LIB_NAME> flags in CMakeList to toggle optional compilation against the system libs.

Tasks

@runlevel5 runlevel5 changed the title [Feature Request] Support ] [Feature Request] Support compilation against shared libs Aug 17, 2023
@runlevel5 runlevel5 changed the title [Feature Request] Support compilation against shared libs [Feature Request] Support compilation against shared system libs Aug 17, 2023
@Connor-GH
Copy link

Connor-GH commented Aug 24, 2023

I was actually just about to open a similar issue. Currently, on gentoo (with normal glibc), there exists a bug where compilation fails because of a zlib OF macro (https://bugs.gentoo.org/show_bug.cgi?id=383179). This prevents the zlib library from building, and as a result also prevents Q2RTX from building. If the system library had been used, the gentoo maintainers' fix would have already been used to let the library build, and Q2RTX could just use that.

(by the way, the fix for gentoo systems compiling zlib is to specify -DOF\(x\)=x at the command line.)

There also used to exist a bug where the Q2RTX-provided SDL2 did not allow proper linking with wlroots-based display servers.

@runlevel5
Copy link
Contributor Author

If the core team is okay with this feature request, I could provide patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants