Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to compile against shared SDL2 #393

Closed
wants to merge 3 commits into from

Conversation

runlevel5
Copy link
Contributor

@runlevel5 runlevel5 commented Mar 27, 2024

Issue

#306

Motivation

Having the flexibility to opt in shared system lib is a big plus for packaging

Changes

  • Add USE_SYSTEM_SDL2 option
  • Update headers path to have SDL2/ prefix (all modern Linux distro have headers in /usr/include/SDL2/)
  • Add header shims for Windows platform

@runlevel5 runlevel5 marked this pull request as draft March 27, 2024 11:47
@runlevel5 runlevel5 marked this pull request as ready for review March 27, 2024 12:16
@apanteleev
Copy link
Collaborator

Merged to master before you did the opposite. Closing.
(Please don't update PRs with master, that just complicates things)

@apanteleev apanteleev closed this Apr 2, 2024
@runlevel5 runlevel5 deleted the sdl2-shared branch April 2, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants