Make tp.Layernorm 1:1 with torch
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkraay
force-pushed
the
dev-mkraay-integration-test-for-layernorm
branch
from
c4d09f1 to
2e033cd
Compare
markkraay
changed the title
tp.Layernormtp.Layernorm 1:1 with torch
akhilg-nv
reviewed
Aug 22, 2024
akhilg-nv
reviewed
Aug 22, 2024
parthchadha
reviewed
Aug 23, 2024
parthchadha
approved these changes
Aug 23, 2024
pmarathe25
reviewed
Aug 23, 2024
pmarathe25
reviewed
Aug 23, 2024
markkraay
force-pushed
the
dev-mkraay-integration-test-for-layernorm
branch
from
134ab9c to
27a6ee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalized_shapeargument 1:1 with Torch. Previously, our API only supported taking a single integer for the normalization dimension. Now, a list of integers can be provided.tp.LayerNormandtp.GroupNorm