Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reduce dims to work with multiple negative dims #136

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

markkraay
Copy link
Collaborator

  • Adds test cases for multiple negative reduce dims, e.g.
a = tp.ones((5,5,5))
tp.sum(a, dim=[-2,-1]
  • Fixes the _reduce_impl to ensure negatives are sorted in decreasing order when performing unsqueeze

@markkraay markkraay self-assigned this Aug 21, 2024
@markkraay markkraay merged commit 977f653 into main Aug 21, 2024
1 check passed
@markkraay markkraay deleted the dev-mkraay-fix-reduce-dims branch August 21, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants