Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tripy] Separate converting shape args from converting tensor args #217

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

slyubomirsky
Copy link
Collaborator

Addresses issue #214 and separates shape argument conversion from the convert_inputs_to_tensors decorator. Since most uses of the shape argument conversion would only convert one argument (usually named shape), this decorator takes a list of arguments to convert rather than converting all arguments by default. It also does not accept arguments that aren't sequences of Python numbers or Tripy Tensors, since it would make less sense to allow external data formats to silently pass through in cases that aren't operator overloads.

@slyubomirsky slyubomirsky added the tripy Pull request for the tripy project label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tripy Pull request for the tripy project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants