Added array_equal function and tests #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkraay
changed the title
| [1, 1], | ||
| [1, 1] | ||
| ]) | ||
| assert tp.array_equal(a, b) |
There was a problem hiding this comment.
asserts are stripped from docs. Probably want:
Suggested change
| assert tp.array_equal(a, b) | |
| # doc: print-locals a b is_equal | |
| is_equal = tp.array_equal(a, b) | |
| assert is_equal |
(the comment could go at the top of the example)
markkraay
force-pushed
the
dev-mkraay-add-array-equal
branch
from
1ea72fd
to
873c90a
Compare
|
@pranavm-nvidia Should we auto-convert input tensors to |
I'm not entirely sure. You could make this argument for pretty much all Tripy APIs. Let's discuss offline. |
markkraay
force-pushed
the
dev-mkraay-add-array-equal
branch
from
873c90a
to
76426e2
Compare
Due to a lack of support for constructing memrefs with negative strides
Constructing a tp.Tensor over np.broadcast_to is problematic.
markkraay
force-pushed
the
dev-mkraay-add-array-equal
branch
from
76426e2
to
44f901c
Compare
Comment on lines
+54
to
+55
| if a.dtype != b.dtype: | ||
| b = cast(b, a.dtype) |
There was a problem hiding this comment.
Shouldn't we return False here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #37, noticed that we were using
tp.allclosein contexts where we should probably be using something similar tonp.array_equalinstead. This MR will:tp.array_equaltp.allclose(we should probably only be usingtp.allclosewhen working with float tensors)np.array_equal(cp.from_dlpack(_).get()trick to usetp.array_equal