Skip to content

Conversation

@yiqingy0
Copy link
Collaborator

@yiqingy0 yiqingy0 commented Nov 7, 2025

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated version constraints for a core dependency to ensure improved compatibility and system stability.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yiqing Yan <[email protected]>
@yiqingy0 yiqingy0 requested a review from chzblych November 7, 2025 09:03
@yiqingy0 yiqingy0 requested a review from a team as a code owner November 7, 2025 09:03
@yiqingy0
Copy link
Collaborator Author

yiqingy0 commented Nov 7, 2025

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

📝 Walkthrough

Walkthrough

The ONNX dependency version constraint in requirements.txt has been narrowed from >=1.18.0 (unbounded) to >=1.18.0,<1.20.0, establishing an upper version limit at 1.20.0.

Changes

Cohort / File(s) Summary
Dependency constraint update
requirements.txt
Narrowed ONNX version range from >=1.18.0 to >=1.18.0,<1.20.0, adding upper bound limit at version 1.20.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is completely empty, containing only the template structure with no actual content filled in for Description or Test Coverage sections. Add a clear description explaining why the ONNX version needs to be locked to <1.20.0 and what test coverage exists for this change. Complete the Description and Test Coverage sections.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: locking the onnx version to <1.20.0, which is reflected in the requirements.txt update from >=1.18.0 to >=1.18.0,<1.20.0.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
requirements.txt (1)

11-11: Add explanatory comment referencing ONNX 1.20.0 breaking changes.

ONNX 1.20.0 introduces breaking changes including operator spec clarifications, dependency changes (ml-dtypes requirement, re2 removal), and deprecations. The version constraint is correct and justified, but lacks inline documentation for maintainability. For a release branch, users should understand why this constraint exists.

Add a comment referencing the breaking changes:

+# ONNX 1.20.0+ introduces breaking changes (ml-dtypes dependency, operator spec updates, deprecations)
 onnx>=1.18.0,<1.20.0
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cf3f0c and 21525e8.

📒 Files selected for processing (1)
  • requirements.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23842 [ run ] triggered by Bot. Commit: 21525e8

@nv-guomingz nv-guomingz added the Cherry-pick It's a label that applies to Cherry-pick PR. label Nov 7, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23842 [ run ] completed with state SUCCESS. Commit: 21525e8
/LLM/release-1.1/L0_MergeRequest_PR pipeline #452 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: Yanchao Lu <[email protected]>
@chzblych
Copy link
Collaborator

chzblych commented Nov 8, 2025

/bot run --skip-test

@chzblych chzblych changed the title [None][chore] Lock onnx version <1.20.0 [None][chore] Lock onnx version <1.20.0 and remove WAR for TRT 10.13 Nov 8, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23901 [ run ] triggered by Bot. Commit: 685a8a0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23901 [ run ] completed with state SUCCESS. Commit: 685a8a0
/LLM/release-1.1/L0_MergeRequest_PR pipeline #455 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
@chzblych
Copy link
Collaborator

chzblych commented Nov 9, 2025

/bot run --skip-test

1 similar comment
@chzblych
Copy link
Collaborator

chzblych commented Nov 9, 2025

/bot run --skip-test

Signed-off-by: Yanchao Lu <[email protected]>
@chzblych
Copy link
Collaborator

chzblych commented Nov 9, 2025

/bot run --skip-test

2 similar comments
@chzblych
Copy link
Collaborator

chzblych commented Nov 9, 2025

/bot run --skip-test

@chzblych
Copy link
Collaborator

chzblych commented Nov 9, 2025

/bot run --skip-test

Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
@chzblych
Copy link
Collaborator

/bot run --skip-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23937 [ run ] triggered by Bot. Commit: 94cc951

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23937 [ run ] completed with state SUCCESS. Commit: 94cc951
/LLM/release-1.1/L0_MergeRequest_PR pipeline #459 (Partly Tested) completed with status: 'SUCCESS'

@chzblych chzblych merged commit 572f9be into NVIDIA:release/1.1 Nov 10, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cherry-pick It's a label that applies to Cherry-pick PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants