-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flash attention support softcap. #1013
Open
Lzhang-hub
wants to merge
11
commits into
NVIDIA:main
Choose a base branch
from
Lzhang-hub:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
34adf28
support softcap for flash-attn
Lzhang-hub f6cd21c
update flash-attn max version
Lzhang-hub 7050f7b
delete noused code
Lzhang-hub 36face8
update flash attn verion in setup
Lzhang-hub cfbc218
no log attention backend
Lzhang-hub cfe16c3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 57d05ac
back
Lzhang-hub 5b75edc
Merge branch 'main' of https://github.com/Lzhang-hub/TransformerEngine
Lzhang-hub 61c5a94
check flash-attn for softcap
Lzhang-hub 28df6cc
Merge branch 'main' into main
Lzhang-hub 7851ab3
softcap added to fa_optional_forward_kwargs
Lzhang-hub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be added to the fa_optional_forward_kwargs instead? Otherwise the previous versions of FA will complain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, it is my fault