Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added offloading support FP8 attention #1131

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

sanandaraj5597
Copy link
Contributor

This PR allows offloading the QKV activation tensors for FP8 Attention.

Signed-off-by: Selvaraj Anandaraj <[email protected]>
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can CPU offloading handle recieving None in the tensor list? #1143 adds some cases where the FP8 tensors are not saved.

@sanandaraj5597
Copy link
Contributor Author

Can CPU offloading handle recieving None in the tensor list? #1143 adds some cases where the FP8 tensors are not saved.

Yes, it can handle.

Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Selvaraj Anandaraj <[email protected]>
@ksivaman
Copy link
Member

ksivaman commented Sep 4, 2024

/te-ci pytorch

Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@cyanguwa cyanguwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman ksivaman merged commit 454e389 into NVIDIA:main Sep 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants