Fix QKV dtype in the bwd of FP8+CP #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiaowei Ren <[email protected]>
|
Can we test both the E4M3 and HYBRID fp8 recipes please? Can we add that to the unit tests? |
This is easy, we just need to change a flag of FP8 recipe, but I think this probably will not add anything additional to the test. I am comparing the results of CP>1 vs. CP=1. E4M2 and HYBRID share the same code, and I think HYBRID test can cover everything of E4M3. For example the bug in this PR is for HYBRID only, it should work for E4M3 because fwd and bwd dtype are same. Maybe I am misunderstanding your point. In your mind, do you have anything special of E4M3 that cannot be covered by HYBRID test? |
Signed-off-by: Xiaowei Ren <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Xiaowei Ren <[email protected]>
|
/te-ci pytorch |
Signed-off-by: Xiaowei Ren <[email protected]>
|
/te-ci pytorch |
|
/te-ci pytorch |
ptrendx
pushed a commit
that referenced
this pull request
Aug 31, 2024
* fix qkv_dtype of FP8+CP Signed-off-by: Xiaowei Ren <[email protected]> * config cp correction dtype of FP8+CP Signed-off-by: Xiaowei Ren <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * code style change Signed-off-by: Xiaowei Ren <[email protected]> * always do FP8 CP correction in FP32 Signed-off-by: Xiaowei Ren <[email protected]> --------- Signed-off-by: Xiaowei Ren <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Charlene Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the QKV dtype in the bwd of FP8+CP.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: