Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save fp8 q/k/v/out tensors when using bf16 bprop #1139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guyueh1
Copy link

@guyueh1 guyueh1 commented Aug 27, 2024

Description

When using FP8_DPA=1 NVTE_FP8_DPA_BWD=0, the backprop uses BF16 q/k/v/out tensors and the fp8 q/k/v/o are not used. So we should avoid saving them for backprop, which reduces the peak memory footprint.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ksivaman
Copy link
Member

/te-ci pytorch

@ksivaman ksivaman self-requested a review August 27, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants