[PyTorch] Add contiguous check for te_grouped_gemm
#1146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type of input and output of
te_grouped_gemm
isstd::vector<at::Tensor>
. If the tensor is not contiguous it will causes potential accuracy problem and it is hard to debug. It's a useful safe operator to check every tensor is contiguous.Why use
is_contiguous
instead ofcontiguous
?If tensor is non-contiguous
contiguous
will call aten::clone to generate a new tensor. It will cause potential performance fallback and generally user is hard to find reason (maybe them need profile).Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
te_grouped_gemm
Checklist: