-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PyTorch] Miscellaneous fixes for FA3 FP8 attention #1174
Open
cyanguwa
wants to merge
15
commits into
NVIDIA:main
Choose a base branch
from
cyanguwa:add_descales
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlene Yang <[email protected]>
for more information, see https://pre-commit.ci
/te-ci pytorch |
Signed-off-by: Charlene Yang <[email protected]>
for more information, see https://pre-commit.ci
ptrendx
reviewed
Sep 17, 2024
/te-ci pytorch |
FA3: pipeline 18489052 |
Signed-off-by: Charlene Yang <[email protected]>
This reverts commit 19e7f87. Signed-off-by: Charlene Yang <[email protected]>
Signed-off-by: Charlene Yang <[email protected]>
Signed-off-by: Charlene Yang <[email protected]>
cyanguwa
changed the title
[PyTorch] Add qkv descales to FA3
[PyTorch] Miscellaneous fixes for FlashAttention with FA3
Sep 18, 2024
cyanguwa
changed the title
[PyTorch] Miscellaneous fixes for FlashAttention with FA3
[PyTorch] Miscellaneous fixes for FA3 FP8 attention
Sep 18, 2024
Signed-off-by: Charlene Yang <[email protected]>
for more information, see https://pre-commit.ci
/te-ci pytorch |
Signed-off-by: Charlene Yang <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Charlene Yang <[email protected]>
/te-ci pytorch |
FA3 pipeline 18528978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a few changes to the FA3 FP8 attention path:
descale_q
,descale_k
anddescale_v
to the FA3 call. This allows custom descaling factors for q/k/v instead of 1s. This requires FA3 PR 1210.qkv_format=sbhd
case whenfp8_mha=true
.Type of change
Changes
Please list the changes introduced in this PR:
Checklist: