Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Common] Default CUDA_HOME to /usr/local/cuda when dynamically loading cuDNN and NVRTC #1183

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

denera
Copy link
Collaborator

@denera denera commented Sep 16, 2024

Description

This PR ensures that we always look for cuDNN and NVRTC under /usr/local/cuda when importing Transformer Engine without requiring CUDA_HOME or CUDA_PATH to be set to the default CUDA installation path. The user should only need to set these variables if CUDA is installed in a non-standard/custom path.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

  • Dynamically loading cuDNN and NVRTC now always falls back on checking /usr/local/cuda when CUDA_HOME or CUDA_PATH variables are not set.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@denera denera self-assigned this Sep 16, 2024
…ynamically load cuDNN and NVRTC

Signed-off-by: Alp Dener <[email protected]>
@denera
Copy link
Collaborator Author

denera commented Sep 16, 2024

/te-ci pytorch

Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's run the full CI though not just pytorch @denera

@denera
Copy link
Collaborator Author

denera commented Sep 16, 2024

/te-ci

Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. It would be better to check in LD_LIBRARY_PATH before trying /usr/local/cuda, although this is a nit.

@denera denera merged commit 44fd316 into NVIDIA:main Sep 17, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants