Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying cmake setup directory #1186

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Allow specifying cmake setup directory #1186

merged 1 commit into from
Sep 17, 2024

Conversation

ryxli
Copy link
Contributor

@ryxli ryxli commented Sep 16, 2024

Description

Please include a brief summary of the changes, relevant motivation and context.

Allow specifying which directory to store cmake build cache, which makes user defined docker buildx workflows more flexible.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • [x ] I have read and followed the contributing guidelines
  • [x ] The functionality is complete
  • [na] I have commented my code, particularly in hard-to-understand areas
  • [na ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [na] I have added tests that prove my fix is effective or that my feature works
  • [na] New and existing unit tests pass locally with my changes

@ptrendx
Copy link
Member

ptrendx commented Sep 16, 2024

Hello @ryxli, could you please sign your commits (https://github.com/NVIDIA/TransformerEngine/blob/main/CONTRIBUTING.rst#sign-your-work)?

build_tools/build_ext.py Outdated Show resolved Hide resolved
@timmoon10 timmoon10 self-requested a review September 16, 2024 22:57
@timmoon10
Copy link
Collaborator

/te-ci

@timmoon10 timmoon10 merged commit 28f95bd into NVIDIA:main Sep 17, 2024
31 checks passed
ptrendx pushed a commit that referenced this pull request Sep 27, 2024
Allow specifying cmake directory

Signed-off-by: Ryan Li <[email protected]>
Co-authored-by: Ryan Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants