Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore compatibility with Python 3.8 #1189

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Restore compatibility with Python 3.8 #1189

merged 2 commits into from
Sep 20, 2024

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Sep 17, 2024

Description

with statement with parentheses was introduced in Python 3.10.

Fixes #1177

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Changed with statements to not use parentheses

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ptrendx
Restore compatibility with Python 3.8
e1252b1 
Signed-off-by: Przemyslaw Tredak <[email protected]>
timmoon10
timmoon10 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

ksivaman
ksivaman approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptrendx
Copy link
Member Author

ptrendx commented Sep 18, 2024

/te-ci pytorch

1 similar comment
@ptrendx
Copy link
Member Author

ptrendx commented Sep 19, 2024

/te-ci pytorch

@ptrendx ptrendx merged commit 0c74535 into NVIDIA:main Sep 20, 2024
26 checks passed
ptrendx added a commit that referenced this pull request Sep 20, 2024
@ptrendx @pre-commit-ci
Restore compatibility with Python 3.8 (#1189)
6a2109f 
* Restore compatibility with Python 3.8

Signed-off-by: Przemyslaw Tredak <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Przemyslaw Tredak <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksivaman ksivaman ksivaman approved these changes

@timmoon10 timmoon10 timmoon10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New format for with statement does not compatible with python 3.8
3 participants
@ptrendx @timmoon10 @ksivaman