Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missed arguments of apply_rotary_pos_emb in MHA #1296

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Add missed arguments of apply_rotary_pos_emb in MHA #1296

merged 5 commits into from
Oct 30, 2024

Conversation

xrennvidia
Copy link
Collaborator

@xrennvidia xrennvidia commented Oct 29, 2024 •
edited
Loading

Description

Add missed arguments of apply_rotary_pos_emb in MHA

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@xrennvidia
Copy link
Collaborator Author

/te-ci pytorch

yaox12
yaox12 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@yaox12 yaox12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xrennvidia xrennvidia mentioned this pull request Oct 29, 2024
Closed
13 tasks
@xrennvidia
Copy link
Collaborator Author

/te-ci pytorch

@xrennvidia xrennvidia closed this Oct 29, 2024
@xrennvidia xrennvidia reopened this Oct 29, 2024
cyanguwa
cyanguwa approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@cyanguwa cyanguwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xrennvidia xrennvidia merged commit ed1e85c into NVIDIA:main Oct 30, 2024
14 checks passed
@xrennvidia xrennvidia deleted the xren/cp_mha_rope branch October 30, 2024 00:24
timmoon10 pushed a commit that referenced this pull request Oct 31, 2024
@xrennvidia @pre-commit-ci @timmoon10
Add missed arguments of apply_rotary_pos_emb in MHA (#1296)
7f2afaa 
* add missed arguments of apply_rotary_pos_emb in MHA

Signed-off-by: Xiaowei Ren <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove an unnecessary f

Signed-off-by: Xiaowei Ren <[email protected]>

* add one more assert for cp_group len

Signed-off-by: Xiaowei Ren <[email protected]>

---------

Signed-off-by: Xiaowei Ren <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyanguwa cyanguwa cyanguwa approved these changes

@yaox12 yaox12 yaox12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrennvidia @yaox12 @cyanguwa