Skip to content

Fix cppunittest test.sh for editable installs #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix cppunittest test.sh for editable installs #1869

wants to merge 7 commits into from

Conversation

jberchtold-nvidia
Copy link
Collaborator

Description

The C++ unittests were looking in the wrong directory for the transformer engine shared library when using an editable install.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Support editable installs for cpp unit tests with qa/L0_cppunittest/test.sh
  • Add test_memset.cu to test file list in CMakeLists.txt as it was missing

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jberchtold-nvidia jberchtold-nvidia force-pushed the dev/jberchtold/fix-cpp-unit-tests-for-editable-installs branch from ba1e365 to 06ad234 Compare June 11, 2025 20:48
@jberchtold-nvidia
Copy link
Collaborator Author

/te-ci L0

timmoon10
timmoon10 reviewed Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, pending CI.

ksivaman
ksivaman reviewed Jun 13, 2025
View reviewed changes
@ksivaman
Copy link
Member

/te-ci

@jberchtold-nvidia jberchtold-nvidia changed the title Fix cppunittest test.sh for editable installs [Draft] Fix cppunittest test.sh for editable installs Jun 13, 2025
@ksivaman
Copy link
Member

/te-ci

@ksivaman ksivaman changed the title [Draft] Fix cppunittest test.sh for editable installs Fix cppunittest test.sh for editable installs Jun 14, 2025
@ksivaman
Copy link
Member

/te-ci

@ksivaman
Copy link
Member

/te-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmoon10 timmoon10 timmoon10 left review comments

@ksivaman ksivaman ksivaman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jberchtold-nvidia @ksivaman @timmoon10