Cache modify iterators locally in agent_merge.cuh #6142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids needing to specify the cache modifier in two places and eases integration of NVIDIA#6077
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 43m: Pass: 100%/185 | Total: 6d 20h | Max: 4h 42m | Hits: 79%/190024See results here. |
fbusato
approved these changes
Oct 7, 2025
| merge_sort::reg_to_shared<threads_per_block>(&storage.keys_shared[0], keys_loc); | ||
| __syncthreads(); | ||
| { | ||
| auto keys1_in_cm = try_make_cache_modified_iterator<Policy::LOAD_MODIFIER>(keys1_in); |
Contributor
There was a problem hiding this comment.
nit. cm for "cache modifier` is a really short abbreviation and not very intuitive
Contributor
Author
There was a problem hiding this comment.
I agree, but the use of the variable is so local that I didn't bother with a long and descriptive name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids needing to specify the cache modifier in two places and eases integration of #6077
No relevant SASS changes on sm86 and sm120 for
cub.cpp17.test.device_merge.lid_0. Just a few symbol changes and constants like: