Skip to content

Make nvrtc concept macros a bit more reliable #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

Make nvrtc concept macros a bit more reliable #6397

merged 1 commit into from
Nov 5, 2025
+27 −1

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Oct 30, 2025

This extents the concept macros so that we do not only rely on the line number but also factor in the tempalte arguments to get a unique name

@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 30, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 30, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Progress in CCCL Oct 30, 2025
@miscco miscco changed the title Make nvrtc concept macros a but more reliable Make nvrtc concept macros a bit more reliable Oct 30, 2025
davebayer
davebayer reviewed Oct 30, 2025
View reviewed changes
@davebayer davebayer marked this pull request as ready for review November 4, 2025 16:17
@davebayer davebayer requested a review from a team as a code owner November 4, 2025 16:17
@davebayer davebayer requested a review from wmaxey November 4, 2025 16:17
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Nov 4, 2025
@davebayer
Copy link
Contributor

davebayer commented Nov 4, 2025

pre-commit.ci autofix

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Nov 4, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@davebayer
Copy link
Contributor

davebayer commented Nov 4, 2025

/ok to test 4f70db4

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@miscco miscco enabled auto-merge (squash) November 5, 2025 09:45
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

🥳 CI Workflow Results

🟩 Finished in 2h 57m: Pass: 100%/90 | Total: 2d 08h | Max: 2h 57m | Hits: 78%/218208

See results here.

@miscco miscco merged commit be49fa4 into NVIDIA:main Nov 5, 2025
104 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Nov 5, 2025
@miscco miscco deleted the nvrtc_concept branch November 5, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

@davebayer davebayer davebayer approved these changes

@wmaxey wmaxey Awaiting requested review from wmaxey wmaxey is a code owner automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

Assignees

No one assigned

Labels

None yet

Projects

CCCL
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miscco @davebayer @bernhardmgruber