MVP for disabling nvtx ranges for thrust::seq
#6415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
bernhardmgruber
left a comment
bernhardmgruber
left a comment
There was a problem hiding this comment.
Please fix the remaining two comments, otherwise LGTM.
…cy is not thrust::seq when applicable
Member
Author
|
@bernhardmgruber @miscco now that I am thinking. Is a test expected for these facilities? And should it be under libcu++ better of maybe? Could be in |
Contributor
Good point! Please add a test if you come up with a good idea on how to test it. |
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 34m: Pass: 100%/70 | Total: 3d 15h | Max: 3h 30m | Hits: 19%/115311See results here. |
bernhardmgruber
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6298
by disabling NVTX ranges for
thrust::seq. This PR specifically tracks the thrust algorithms involved inhost_vector::push_back()operations and disables NVTX ranges just for these.The disabling basically evaluates at compile time whether the policy passed to the thrust algorithm (and subsequently to
should_enable_nvtx_for_policy()) isthrust::seqor any derivatives using CRTP.Upon approval of the utility provided here, I will add all the remaining thrust algorithms.
I did isolate and run profiles on the cudf code that pointed to the problem and after the changes I got zero nvtx ranges for these lines in the profile.