Skip to content

[cudax->libcudacxx] Move device_transform to libcu++ #6469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 11, 2025
Merged

[cudax->libcudacxx] Move device_transform to libcu++ #6469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5248f63
Move device_transform to libcu++
pciolkosz Nov 4, 2025
3565914
Fix the transform test
pciolkosz Nov 4, 2025
df4cb61
Give up on immovable device transform for now
pciolkosz Nov 4, 2025
05409f6
algorithm without h
pciolkosz Nov 4, 2025
a76bd7d
Review feedback
pciolkosz Nov 4, 2025
29e4bf6
Add emplace that doesn't move
pciolkosz Nov 4, 2025
e3b7936
Merge remote-tracking branch 'upstream/main' into move_device_transfo…
pciolkosz Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cudax/examples/simple_p2p.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@
* Unified Virtual Address Space (UVA) features.
*/

#include <cuda/algorithm>
#include <cuda/devices>
#include <cuda/memory_resource>

#include <cuda/experimental/algorithm.cuh>
#include <cuda/experimental/container.cuh>
#include <cuda/experimental/launch.cuh>
#include <cuda/experimental/memory_resource.cuh>
Expand Down Expand Up @@ -91,11 +91,11 @@ void benchmark_cross_device_ping_pong_copy(
// Ping-pong copy between GPUs
if (i % 2 == 0)
{
cudax::copy_bytes(dev1_stream, dev0_buffer, dev1_buffer);
cuda::copy_bytes(dev1_stream, dev0_buffer, dev1_buffer);
}
else
{
cudax::copy_bytes(dev1_stream, dev1_buffer, dev0_buffer);
cuda::copy_bytes(dev1_stream, dev1_buffer, dev0_buffer);
}
}

Expand Down Expand Up @@ -126,7 +126,7 @@ void test_cross_device_access_from_kernel(
return static_cast<float>((i++) % 4096);
});

cudax::copy_bytes(dev0_stream, host_buffer, dev0_buffer);
cuda::copy_bytes(dev0_stream, host_buffer, dev0_buffer);
dev1_stream.wait(dev0_stream);

// Kernel launch configuration
Expand All @@ -151,7 +151,7 @@ void test_cross_device_access_from_kernel(

// Copy data back to host and verify
printf("Copy data back to host from GPU%d and verify results...\n", dev0.get());
cudax::copy_bytes(dev0_stream, dev0_buffer, host_buffer);
cuda::copy_bytes(dev0_stream, dev0_buffer, host_buffer);
dev0_stream.sync();

int error_count = 0;
Expand Down
69 changes: 0 additions & 69 deletions cudax/include/cuda/experimental/__algorithm/common.cuh
View file
Open in desktop

This file was deleted.

94 changes: 0 additions & 94 deletions cudax/include/cuda/experimental/__algorithm/copy.cuh
View file
Open in desktop

This file was deleted.

78 changes: 0 additions & 78 deletions cudax/include/cuda/experimental/__algorithm/fill.cuh
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion cudax/include/cuda/experimental/__launch/launch.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#endif // no system header

#include <cuda/__driver/driver_api.h>
#include <cuda/__stream/device_transform.h>
#include <cuda/__stream/stream_ref.h>
#include <cuda/std/__exception/cuda_error.h>
#include <cuda/std/__type_traits/is_function.h>
Expand All @@ -38,7 +39,6 @@
#include <cuda/experimental/__graph/path_builder.cuh>
#include <cuda/experimental/__kernel/kernel_ref.cuh>
#include <cuda/experimental/__launch/configuration.cuh>
#include <cuda/experimental/__stream/device_transform.cuh>
#include <cuda/experimental/__utility/ensure_current_device.cuh>

#include <cuda/std/__cccl/prologue.h>
Expand Down
17 changes: 0 additions & 17 deletions cudax/include/cuda/experimental/algorithm.cuh
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion cudax/include/cuda/experimental/launch.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@
#ifndef __CUDAX_LAUNCH___
#define __CUDAX_LAUNCH___

#include <cuda/__stream/device_transform.h>

#include <cuda/experimental/__launch/configuration.cuh>
#include <cuda/experimental/__launch/host_launch.cuh>
#include <cuda/experimental/__launch/launch.cuh>
#include <cuda/experimental/__launch/param_kind.cuh>
#include <cuda/experimental/__stream/device_transform.cuh>

#endif // __CUDAX_LAUNCH___
2 changes: 1 addition & 1 deletion cudax/test/algorithm/common.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
#ifndef __ALGORITHM_COMMON__
#define __ALGORITHM_COMMON__

#include <cuda/algorithm>
#include <cuda/memory_resource>
#include <cuda/std/mdspan>

#include <cuda/experimental/algorithm.cuh>
#include <cuda/experimental/container.cuh>
#include <cuda/experimental/memory_resource.cuh>

Expand Down
Loading