Fixes a bug with C++ argument handling in the front end. (#2459)

This one particular path was not making sure the arguments were relaxed when they needed to be resulting in a type error. As a bonus, corrects the bernstein_vazirani example. Signed-off-by: Eric Schweitz <[email protected]>
NVIDIA · Dec 10, 2024 · 917146d · 917146d
1 parent 95a4da7
commit 917146d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/docs/sphinx/applications/cpp/bernstein_vazirani.cpp b/docs/sphinx/applications/cpp/bernstein_vazirani.cpp
@@ -34,7 +34,7 @@ std::vector<bool> random_bits(int seed) {
 
 template <int nrOfBits>
 struct oracle {
-  auto operator()(std::vector<bool> bitvector, cudaq::qview<> qs,
+  auto operator()(std::vector<bool> &bitvector, cudaq::qview<> qs,
                   cudaq::qubit &aux) __qpu__ {
 
     for (size_t i = 0; i < nrOfBits; i++) {

diff --git a/lib/Frontend/nvqpp/ConvertExpr.cpp b/lib/Frontend/nvqpp/ConvertExpr.cpp
@@ -2310,8 +2310,10 @@ bool QuakeBridgeVisitor::VisitCXXOperatorCallExpr(
         // replace it with an indirect call to the func::ConstantOp.
         auto indirect = popValue();
         auto funcTy = cast<FunctionType>(indirect.getType());
+        auto convertedArgs =
+            convertKernelArgs(builder, loc, 0, args, funcTy.getInputs());
         auto call = builder.create<func::CallIndirectOp>(
-            loc, funcTy.getResults(), indirect, args);
+            loc, funcTy.getResults(), indirect, convertedArgs);
         if (call.getResults().empty())
           return true;
         return pushValue(call.getResult(0));