Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core, runtime] Modify the launchers to support returning results. #2277

Merged
merged 3 commits into from
Oct 18, 2024
Merged

[core, runtime] Modify the launchers to support returning results. #2277

merged 3 commits into from
Oct 18, 2024

Commits on Oct 18, 2024

  1. Modify the launchers to support returning results. 

    The launchers ceased really supporting dynamic kernel results
at some point. This PR adds that functionality back into the
mix. This support is added pervasively across the runtime
library calls.

Some notes:

  - Return values of static size continue to be supported as
    they were before. Specifically, these values are stored
    into the data buffer by the thunk adaptor so they can be
    returned, ultimately, to the original caller.

  - Return values of dynamic size follow exactly 1 of 2
    possible calling conventions. The convention must be
    selected by the runtime layers.

    1. Everything is running within a single process; i.e.,
       this is a simulation. In this case, the kernel will
       create a span of data and that span will be returned
       to the original caller which will use it to construct
       the std::vector result object.

    2. There are multiple processes and/or memory spaces
       involved. The result span will be appended to the
       original data packet and the new data packet will be
       returned as a new span by the runtime. The calling
       code will follow a similar process, but the data will
       be passed in the runtime in a pointer-free encoding.

Make the cast more robust to sneak it past -Werror.

Update another launchKernel override.

Add some doxygen goop to try an evade CI issues.

Fix the python builder errors.

Sachin's fix.

Signed-off-by: Eric Schweitz <[email protected]>
    @schweitzpgi
    schweitzpgi committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d8a2596 View commit details
    Browse the repository at this point in the history

  2. Add back lost files. 

    Signed-off-by: Eric Schweitz <[email protected]>
    @schweitzpgi
    schweitzpgi committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    30b2585 View commit details
    Browse the repository at this point in the history

  3. https://breathe.readthedocs.io/en/latest/struct.html 

    Signed-off-by: Eric Schweitz <[email protected]>
    @schweitzpgi
    schweitzpgi committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3267d2d View commit details
    Browse the repository at this point in the history