Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tensornet] Support trajectory simulation for unitary mixture noise channels #2520

Merged
merged 25 commits into from
Feb 6, 2025
Merged

[Tensornet] Support trajectory simulation for unitary mixture noise channels #2520

merged 25 commits into from
Feb 6, 2025

Conversation

1tnguyen
Copy link
Collaborator

@1tnguyen 1tnguyen commented Jan 20, 2025 •
edited
Loading

Description

(1) Add support for cutensornetStateApplyUnitaryChannel

  • Perform trajectory-based simulation if there are noise ops applied to the state.

  • Throw error if seeing non-unitary noise ops.

  • MPS has a custom implementation (override) for trajectory sample/observe as it needs to recompute the state for each trajectory.

  • Enable noise tests for tensornet backends.

(2) Some minor updates to tensornet backends

  • Replace a couple of deprecating enums.

  • Make the number of hyper samples a configuration param and add the corresponding doc.

@1tnguyen
Initial work on adding support for cutensornetStateApplyUnitaryChannel
eeaf2ef 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Enable some noise test cases on tensornet
4914555 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Fix a copy-and-paste error
a3980c2 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
support unitary mixture channel detection and enable more tests
d01763b 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
MPS trajectory: we need to compute the MPS factorization for each tra…
2851826 
…jectory

Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Merge branch 'main' into tnguyen/tensornet-trajectory
79265d4 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Split cutensornetStateFinalizeMPS and (cutensornetStatePrepare + cute…
fdcbb06 
…nsornetStateCompute)

The first one is only needed once for trajectory simulation.

Signed-off-by: Thien Nguyen <[email protected]>
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 20, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
3a8454b
@1tnguyen
Add trajectories to observe
1207435 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Handle unitary channels in all code paths
aef8b63 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Code format
be2d38e 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Reduce test time
2be6d46 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Update cutensornet version requirement
bbc1d13 
Signed-off-by: Thien Nguyen <[email protected]>
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
4cf6152
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
50f73d2
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
4e9b2e8
@1tnguyen
Add cache workspace mem
e27be87 
Signed-off-by: Thien Nguyen <[email protected]>
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
085ebea
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
830a3ee
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@sacpis
Copy link
Collaborator

sacpis commented Jan 30, 2025

Once we modularize the long functions, can we please throw in some unittests? I will go through the PR again once we have the changes.

@1tnguyen 1tnguyen changed the title [WIP][Tensornet] Support trajectory simulation for unitary mixture noise channels [Tensornet] Support trajectory simulation for unitary mixture noise channels Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
76fdf99
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
a1f6416
@1tnguyen
Copy link
Collaborator Author

Once we modularize the long functions, can we please throw in some unittests? I will go through the PR again once we have the changes.

Thanks. I added a new unit test for the matrix representation bug that is not detectable by sample/observe tests. The existing tests in noise_tester.cpp (now enabled for cutensornet backends) would cover noisy simulation functionality.

github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
c7f9c1d
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

sacpis
sacpis reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with few changes. :)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 3, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
44e5fb5
sacpis
sacpis approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just 1 question. Thanks @1tnguyen.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
@cuda-quantum-bot
Docs preview for PR #2520.
6ed8602
@1tnguyen 1tnguyen merged commit 8e54384 into NVIDIA:main Feb 6, 2025
213 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
@cuda-quantum-bot
Cleaning up docs preview for PR #2520.
31220e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacpis sacpis sacpis approved these changes

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1tnguyen @sacpis