Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quake Circuit Cutting #514

Closed
wants to merge 20 commits into from
Closed

Quake Circuit Cutting #514

wants to merge 20 commits into from

Conversation

amccaskey
Copy link
Collaborator

@amccaskey amccaskey commented Aug 1, 2023 •
edited
Loading

Introduce new MLIR Pass that takes a single Quake function in the value-semantic model and partitions the corresponding circuit into k sub-circuits using METIS. Reconstitutes each partition into a new Quake function with inserted measure and state preparation nodes. These nodes can be search/replaced via another upcoming pass before JIT execution via NVQIR simulation.

Workflow steps:

  • Map value-semantic Quake to DAG structure.
  • Convert DAG to undirected METIS graph input
  • Partition with METIS
  • Create DAG representation for each partitition
  • Insert measurement and state preparation nodes
  • Reconstitute DAG to Quake MLIR function
  • Add to the ModuleOp.

bettinaheim
bettinaheim previously requested changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested "changes" is a conversation about how we want to support this more permanently. Specifically, if we should write our own graph partition library and/or what library we depend on in the meantime or permanently.

test/Quake/circuit-cutting.qke Outdated Show resolved Hide resolved
bettinaheim
bettinaheim reviewed Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Metis to the Notice file in any case. Even if we are not including it in the release, it is in the devdeps image and it is also very easy to forget adding it in the future if we ever include it.

lib/Support/partitioners/CMakeLists.txt Outdated Show resolved Hide resolved
scripts/install_prerequisites.sh Outdated Show resolved Hide resolved
scripts/install_prerequisites.sh Outdated
temp_install_if_command_unknown gcc gcc

git clone https://github.com/KarypisLab/GKlib
cd GKlib && make config cc=gcc prefix=$METIS_INSTALL_PREFIX openmp=set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does openmp=set mean that running the metis graph partiationer will cause a runtime failure if openmp is not installed in the dev environment?

docker/build/devdeps.manylinux.Dockerfile Outdated Show resolved Hide resolved
scripts/build_cudaq.sh Outdated Show resolved Hide resolved
docker/build/devdeps.Dockerfile Outdated Show resolved Hide resolved
boschmitt
boschmitt reviewed Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@boschmitt boschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a partial review.

lib/Optimizer/CodeGen/QuakeCircuitCutPass.cpp Outdated Show resolved Hide resolved
lib/Optimizer/CodeGen/QuakeCircuitCutPass.cpp Outdated Show resolved Hide resolved
lib/Optimizer/CodeGen/QuakeCircuitCutPass.cpp Outdated Show resolved Hide resolved
@amccaskey amccaskey force-pushed the QuakeCircuitCutting branch 2 times, most recently from 470b4bf to acf1d42 Compare August 9, 2023 12:27
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@cuda-quantum-bot
Docs preview for PR #514.
654150d
amccaskey and others added 18 commits August 15, 2023 18:45
@amccaskey
Add Quake Circuit Cutting Pass.
4afebc9 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
remove metis hard-code
1701935 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
remove another hard coded path
4bd75de 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
more cleanup
988148c 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
forgot to remove the src
83af767 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
better handle metis missing
f022322 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
work to make cmake happy
02c4179 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
add empty pass for when there is no metis
7e69cb3 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
create GraphPartitioner interface, pull metis work out behind it, ena…
d2a6703 
…ble one to load it as a plugin

Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
Add destructor
764bb12 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
make partitioner an option
5b3afcd 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
clean up the run command
344c71f 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
forgot trailing slash
bcd1b46 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
Add metis to the CI docker images
96fdcd2 
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey @bettinaheim
Update lib/Support/partitioners/CMakeLists.txt
5dd62b7 
Co-authored-by: Bettina Heim <[email protected]>
@bettinaheim @amccaskey
ensuring that metis is only included in tests but not in images
5143e4a
@bettinaheim @amccaskey
fixing the circuit-cutting test
5ccd7c1
@bettinaheim @amccaskey
making sure the llvm-lit test is marked as unsupported when no partit…
7c8b073 
…ioner plugin is installed, and setting up the test to test all installed plugins
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@cuda-quantum-bot
Docs preview for PR #514.
1e8c0ca
@amccaskey amccaskey marked this pull request as draft August 16, 2023 14:34
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 16, 2023
@cuda-quantum-bot
Docs preview for PR #514.
d215873
@amccaskey
Copy link
Collaborator Author

Closing this, will require a bit more work / though.

@amccaskey amccaskey closed this Aug 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
@amccaskey amccaskey deleted the QuakeCircuitCutting branch February 29, 2024 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bettinaheim bettinaheim bettinaheim left review comments

@boschmitt boschmitt boschmitt left review comments

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen 1tnguyen will be requested when the pull request is marked ready for review 1tnguyen is a code owner

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 will be requested when the pull request is marked ready for review bmhowe23 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amccaskey @boschmitt @schweitzpgi @bettinaheim