Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to #61 - apply first-round data to all shots #85

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

bmhowe23
Copy link
Collaborator

This fixes what I think is a bug with #61. @justinlietz - please verify.

The problem was that the first round data in syndromeTensor was only being copied for shot == 0 and was left uninitialized/uncopied for all other shots.

@bmhowe23 bmhowe23 requested a review from justinlietz February 18, 2025 04:18
@bmhowe23 bmhowe23 enabled auto-merge (squash) February 18, 2025 21:34
Copy link
Collaborator

@justinlietz justinlietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This change should apply to each shot. Both changes look good to me.

@bmhowe23 bmhowe23 merged commit 5ff20e3 into NVIDIA:main Feb 19, 2025
14 checks passed
@bmhowe23 bmhowe23 deleted the pr-first-round-memory-follow-up branch February 19, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants