Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance e2e test and publish image #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enhance e2e test and publish image #117

wants to merge 1 commit into from

Conversation

shivakunv
Copy link
Contributor

No description provided.

@shivakunv shivakunv self-assigned this Sep 13, 2024
@shivakunv shivakunv force-pushed the e2etestandpushimage branch 2 times, most recently from 43a0e71 to d0e004d Compare September 16, 2024 12:46
@shivakunv shivakunv marked this pull request as ready for review September 16, 2024 12:47
shivakunv
shivakunv commented Sep 16, 2024
View reviewed changes
.github/workflows/image.yaml
# SHIVA
# pull_request:
# types:
# - opened
Copy link
Contributor Author

@shivakunv shivakunv Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test code

shivakunv
shivakunv commented Sep 16, 2024
View reviewed changes
.github/workflows/precompiled.yaml
# - opened
# - synchronize
# branches:
# - main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test code

shivakunv
shivakunv commented Sep 16, 2024
View reviewed changes
.github/workflows/precompiled.yaml
needs: set-driver-version-matrix
runs-on: ubuntu-latest
strategy:
matrix:
driver-branch: ${{ fromJson(needs.set-driver-version-matrix.outputs.driver_branch) }}
driver_branch: ${{ fromJson(needs.set-driver-version-matrix.outputs.driver_branch) }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using driver_branch in most of the places

shivakunv
shivakunv commented Sep 16, 2024
View reviewed changes
.github/workflows/precompiled.yaml
@@ -220,19 +270,29 @@ jobs:
- name: Precompiled e2e test gpu driver validation
env:
TEST_CASE: "./tests/cases/nvidia-driver.sh"
GPU_OPERATOR_OPTIONS: "--set driver.repository=${{ env.PRIVATE_REGISTRY }}/nvidia --set driver.usePrecompiled=true"
GPU_OPERATOR_OPTIONS: "--set driver.repository=${{ env.PRIVATE_REGISTRY }}/nvidia --set driver.usePrecompiled=true \
--set driver.imagePullPolicy=Never"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--set driver.imagePullPolicy=Never : use local image uploaded with ctr command on target

@shivakunv shivakunv force-pushed the e2etestandpushimage branch 5 times, most recently from 6b7444a to 0e79215 Compare September 17, 2024 12:49
@shivakunv shivakunv force-pushed the e2etestandpushimage branch 2 times, most recently from a0643fe to 22afef0 Compare September 18, 2024 09:55
shivakunv
shivakunv commented Sep 18, 2024
View reviewed changes
tests/scripts/findkernelversion.sh
regctl tag ls nvcr.io/nvidia/driver | grep "^${DRIVER_BRANCH}-${KERNEL_VERSION}-${DIST}$" || status=$?
if [[ $status -eq 0 ]]; then
export should_continue=false
else
export should_continue=true
fi
# SHIVA
export should_continue=true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shivakunv shivakunv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shivakunv