Add init container to GFD for handling imex nodes config mount #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
| echo "Removing cached IMEX nodes config" | ||
| rm -f /config/${IMEX_NODES_CONFIG_FILE} | ||
| fi | ||
| if [[ ! -f ${DRIVER_ROOT_CTR_PATH}/${IMEX_NODES_CONFIG_FILE} ]]; then |
There was a problem hiding this comment.
Where is DRIVER_ROOT_CTR_PATH being set?
There was a problem hiding this comment.
A few lines above when we source the driver-ready file.
There was a problem hiding this comment.
Here are the logs from the init container now:
cdesiniotis@cnt-imex-devel:~$ kubectl logs -n gpu-operator gpu-feature-discovery-5nd22 -c gpu-feature-discovery-imex-init
IS_HOST_DRIVER=true
NVIDIA_DRIVER_ROOT=/
DRIVER_ROOT_CTR_PATH=/host
NVIDIA_DEV_ROOT=/
DEV_ROOT_CTR_PATH=/host
Copying IMEX nodes config
|
@ArangoGutierrez @tariq1890 do you know why the GitHub actions are not being triggered here? |
tariq1890
requested review from
ArangoGutierrez,
elezar,
shivamerla and
tariq1890
as code owners
|
cdesiniotis
force-pushed
the
gfd-imex-init-container
branch
2 times, most recently
from
43e1a9e
to
401c81d
Compare
Signed-off-by: Christopher Desiniotis <[email protected]>
Signed-off-by: Christopher Desiniotis <[email protected]>
cdesiniotis
force-pushed
the
gfd-imex-init-container
branch
from
401c81d
to
d2c828b
Compare
tariq1890
reviewed
Oct 25, 2024
cdesiniotis
force-pushed
the
gfd-imex-init-container
branch
from
1e42c5f
to
2117822
Compare
Signed-off-by: Christopher Desiniotis <[email protected]>
cdesiniotis
force-pushed
the
gfd-imex-init-container
branch
from
2117822
to
22941b5
Compare
tariq1890
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.