configure crun as the low-level runtime to prioritise when using CRI-O #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
requested review from
ArangoGutierrez,
cdesiniotis,
elezar and
shivamerla
as code owners
tariq1890
force-pushed
the
crun-crio
branch
2 times, most recently
from
cc3f241
to
cac5e00
Compare
Signed-off-by: Tariq Ibrahim <[email protected]>
tariq1890
force-pushed
the
crun-crio
branch
from
cac5e00
to
0509545
Compare
tariq1890
commented
Sep 11, 2024
| // Specify the full paths of the crun and runc executables as the CRI-O installed binaries are not available in the PATH | ||
| if runtime == gpuv1.CRIO.String() { | ||
| setContainerEnv(&(obj.Spec.Template.Spec.Containers[0]), NvidiaCtrRuntimeRuntimesEnvName, | ||
| "/usr/libexec/crio/crun,/usr/libexec/crio/runc,crun,runc") |
There was a problem hiding this comment.
UPDATE: It looks like this assumption does not hold good for ALL cri-o deployments.
In cases of cri-o on OpenShift:
-
The low-level runtime binaries are installed in the following locations:
/usr/bin/runc /usr/bin/crun -
runcis the default runtime as opposed tocrunin vanilla CRI-O
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.