Exclude attestation manifests (sbom, provenance) during the build usi… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivakunv
force-pushed
the
exclude_attestation_manifests
branch
from
245214f
to
f546134
Compare
elezar
reviewed
Jun 24, 2024
There was a problem hiding this comment.
Could you comment on why you followed this approach and not the same one we used in https://github.com/NVIDIA/k8s-device-plugin/pull/765/files where we explicitly add:
--provenance=false --sbom=false \
to the docker build command?
In this method, we can use the ATTACH_ATTESTATIONS environment variable to disable provenance=false and --sbom=false changes. |
shivakunv
force-pushed
the
exclude_attestation_manifests
branch
from
f546134
to
a001b14
Compare
…ng buildx as some tools Signed-off-by: shiva kumar <[email protected]>
shivakunv
force-pushed
the
exclude_attestation_manifests
branch
from
a001b14
to
f849c79
Compare
cdesiniotis
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude attestation manifests (sbom, provenance) during the build using buildx as some tools