Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reduced ubi8 base image #813

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

elezar
Copy link
Member

@elezar elezar commented Jul 11, 2024

These changes apply a set of transforms / cleanups to the CUDA ubi8 base to remove unneeded packages.

@klueska
Copy link
Contributor

klueska commented Jul 11, 2024

Does it make sense to do this somewhere more central and then have all of our operands base their images off of this?

@elezar
Copy link
Member Author

elezar commented Jul 11, 2024

Does it make sense to do this somewhere more central and then have all of our operands base their images off of this?

It may. See NVIDIA/k8s-test-infra#61 where I implemented the initial version of this. My primary concern with doing this centrally is whether we want to consume an image or the scripts instead.

One thought that I had was that we could have component-specific drop-in files in a subfolder or something so that we could customize this as required. Not sure if that's something that we're going to need though.

@elezar elezar requested a review from tariq1890 July 12, 2024 12:23
@elezar elezar force-pushed the reduced-base-image branch 5 times, most recently from 9c47df9 to 8961ddb Compare July 17, 2024 13:39
@elezar elezar force-pushed the reduced-base-image branch 2 times, most recently from b7036b6 to f31a9b2 Compare August 12, 2024 12:43
These changes apply a set of transforms / cleanups to the CUDA ubi8 base
to remove unneeded packages.

Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar marked this pull request as ready for review August 27, 2024 15:32
@elezar elezar changed the title Use minimal ubi8 base image Use reduced ubi8 base image Aug 27, 2024
@elezar elezar requested a review from klueska August 27, 2024 18:20
@elezar elezar merged commit 337ac67 into NVIDIA:main Aug 27, 2024
8 checks passed
@elezar elezar deleted the reduced-base-image branch August 27, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants