-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README fixes/enhancements #832
Conversation
Signed-off-by: Chip Zoller <[email protected]>
Signed-off-by: Chip Zoller <[email protected]>
Signed-off-by: Chip Zoller <[email protected]>
Signed-off-by: Chip Zoller <[email protected]>
Signed-off-by: Chip Zoller <[email protected]>
Signed-off-by: Chip Zoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the review. This look good to go? |
Signed-off-by: chipzoller <[email protected]>
Since this is still open, I added a short paragraph about the scope of sharing. |
Changes seem reasonable to me, I'll leave it to @elezar for final approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chipzoller.
I think these change look good from a content perspective. Definitely some good additions and clarifications.
I would like for the types on the code blocks to be used consistently though and would like to better understand the TOC changes.
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
@elezar anything else here or can we merge? |
Bump |
Folks, this simple readme PR has been outstanding for a month. What more can I do to help update your documentation here? |
Thanks for all your time and help. If you don't object to my suggs and requests, but don't have time, PLMK if it's OK to push a commit. |
Sure, and I'm glad to implement any suggestions as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your willingness to pitch in.
Signed-off-by: chipzoller <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the assist.
We'll look at this after the lint CI job is revised. |
Merged main so CI can probably be kicked off again assuming it pulled in those fixes. |
This PR: