modify the log level of some errors #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
googs1025
commented
Aug 11, 2024
googs1025
commented
- modify the log level of some errors
- fix method comment
googs1025
force-pushed
the
fix_log
branch
2 times, most recently
from
3e1497d
to
b3e3678
Compare
elezar
approved these changes
Sep 17, 2024
elezar
reviewed
Sep 17, 2024
| @@ -157,7 +157,7 @@ func (plugin *NvidiaDevicePlugin) Start() error { | |||
| // TODO: add MPS health check | |||
| err := plugin.rm.CheckHealth(plugin.stop, plugin.health) | |||
| if err != nil { | |||
| klog.Infof("Failed to start health check: %v; continuing with health checks disabled", err) | |||
| klog.Errorf("Failed to start health check: %v; continuing with health checks disabled", err) | |||
There was a problem hiding this comment.
This could also be a warning instead, but I don't think it's a blocker.
There was a problem hiding this comment.
Thanks for your reply :)
|
do we have to fix this ci error? Error: internal/resource/cuda-lib.go:60:15: G115: integer overflow conversion int -> uint (gosec)
major := uint(version) / 1000
^
Error: internal/resource/cuda-lib.go:61:15: G115: integer overflow conversion int -> uint (gosec)
minor := uint(version) % 100 / 10
^
Error: internal/resource/nvml-lib.go:44:15: G115: integer overflow conversion int -> uint (gosec)
major := uint(v / 1000)
^
Error: internal/resource/nvml-mig-device.go:1[31](https://github.com/NVIDIA/k8s-device-plugin/actions/runs/10904087630/job/30259653352?pr=898#step:5:33):16: G115: integer overflow conversion int -> uint64 (gosec)
return uint64(totalMemory.(int)), nil
|
|
friendly ping @elezar |
fix method comment Signed-off-by: googs1025 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.