Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-cleanup-on-exit option to GFD #899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

Add --no-cleanup-on-exit option to GFD #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/config/v1/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ func (f *deviceListStrategyFlag) UnmarshalJSON(b []byte) error {
type GFDCommandLineFlags struct {
Oneshot *bool `json:"oneshot" yaml:"oneshot"`
NoTimestamp *bool `json:"noTimestamp" yaml:"noTimestamp"`
NoCleanupOnExit *bool `json:"noCleanupOnExit" yaml:"noCleanupOnExit"`
SleepInterval *Duration `json:"sleepInterval" yaml:"sleepInterval"`
OutputFile *string `json:"outputFile" yaml:"outputFile"`
MachineTypeFile *string `json:"machineTypeFile" yaml:"machineTypeFile"`
Expand Down Expand Up @@ -168,6 +169,8 @@ func (f *Flags) UpdateFromCLIFlags(c *cli.Context, flags []cli.Flag) {
updateFromCLIFlag(&f.GFD.NoTimestamp, c, n)
case "machine-type-file":
updateFromCLIFlag(&f.GFD.MachineTypeFile, c, n)
case "no-cleanup-on-exit":
updateFromCLIFlag(&f.GFD.NoCleanupOnExit, c, n)
}
}
}
Expand Down
2 changes: 2 additions & 0 deletions api/config/v1/flags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ func TestMarshalFlags(t *testing.T) {
"gfd": {
"oneshot": null,
"noTimestamp": null,
"noCleanupOnExit": null,
"outputFile": null,
"sleepInterval": "0s",
"machineTypeFile": null
Expand All @@ -208,6 +209,7 @@ func TestMarshalFlags(t *testing.T) {
"gfd": {
"oneshot": null,
"noTimestamp": null,
"noCleanupOnExit": null,
"outputFile": null,
"sleepInterval": "5ns",
"machineTypeFile": null
Expand Down
9 changes: 9 additions & 0 deletions cmd/gpu-feature-discovery/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ func main() {
Usage: "Do not add the timestamp to the labels",
EnvVars: []string{"GFD_NO_TIMESTAMP"},
},
&cli.BoolFlag{
Name: "no-cleanup-on-exit",
Value: false,
Usage: "Do not remove the generated label file",
EnvVars: []string{"GFD_NO_CLEANUP_ON_EXIT"},
},
&cli.DurationFlag{
Name: "sleep-interval",
Value: 60 * time.Second,
Expand Down Expand Up @@ -229,6 +235,9 @@ type gfd struct {

func (d *gfd) run(sigs chan os.Signal) (bool, error) {
defer func() {
if d.config.Flags.GFD.NoCleanupOnExit != nil && *d.config.Flags.GFD.NoCleanupOnExit {
return
}
if d.config.Flags.UseNodeFeatureAPI != nil && *d.config.Flags.UseNodeFeatureAPI {
return
}
Expand Down
Loading