Use SELinux package to apply context #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empovit
force-pushed
the
mps-use-selinux-package
branch
from
d4afc48
to
ed999c5
Compare
|
/cc @cdesiniotis @elezar |
elezar
reviewed
Aug 19, 2024
cmd/mps-control-daemon/mps/daemon.go
Outdated
| @@ -98,7 +99,7 @@ func (d *Daemon) Start() error { | |||
| return fmt.Errorf("error creating directory %v: %w", pipeDir, err) | |||
| } | |||
|
|
|||
| if err := setSELinuxContext(pipeDir, "container_file_t"); err != nil { | |||
| if err := setSELinuxContext(pipeDir, "system_u:object_r:container_file_t:s0"); err != nil { | |||
There was a problem hiding this comment.
Is there any chance that this is available as a constant?
There was a problem hiding this comment.
I'm afraid it is not :/ Not in the selinux package or any of the imported packages. But I can make it a constant if that's what you mean.
empovit
force-pushed
the
mps-use-selinux-package
branch
from
ed999c5
to
2065295
Compare
Use `github.com/opencontainers/selinux/go-selinux` instead of calling the `chcon` command to set SELinux context. Signed-off-by: Vitaliy Emporopulo <[email protected]>
elezar
force-pushed
the
mps-use-selinux-package
branch
from
2065295
to
df9a902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
github.com/opencontainers/selinux/go-selinuxinstead of calling thechconcommand to set SELinux context.This PR builds upon #789, but according to opencontainers/selinux/issues/215, a full label must be applied when using the SELinux Go package. Also, checking whether SELinux is available has been changed - the reason was discussed in detail in #847.