Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MIG in kind #12

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Enable MIG in kind #12

merged 2 commits into from
Nov 3, 2023

Conversation

klueska
Copy link
Collaborator

@klueska klueska commented Nov 3, 2023

No description provided.

This is required to allow dynamically generated MIG devices to be discovered

Signed-off-by: Kevin Klues <[email protected]>
@klueska klueska requested a review from elezar November 3, 2023 13:15
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One non-blocking question.


# Unmount the masked /proc/driver/nvidia to allow
# dynamically generated MIG devices to be discovered
docker exec -it "${KIND_CLUSTER_NAME}-worker" umount -R /proc/driver/nvidia
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: If we move to a situation where this is not mounted, will this error out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this will cause an error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to fail silently or with a warning instead? (Sorry should have added this in the first question already).

@klueska klueska merged commit ab776da into NVIDIA:main Nov 3, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants