Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the IMEX controller code #189

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

klueska
Copy link
Collaborator

@klueska klueska commented Oct 25, 2024

No description provided.

@klueska klueska force-pushed the refactor-imex-controller branch 5 times, most recently from 20e8011 to b75081b Compare October 27, 2024 06:56
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add an extra value to transientError to allow us to reject retry when needed

cmd/nvidia-dra-controller/imex.go Show resolved Hide resolved
cmd/nvidia-dra-controller/imex.go Show resolved Hide resolved
This indicates a transient failure that will be resolved if fewer
clique ids are used in the future for the same domain.

Signed-off-by: Kevin Klues <[email protected]>
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now
TODO: @ArangoGutierrez write tests

@klueska klueska merged commit 86cbafc into NVIDIA:main Oct 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants