-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace CONTAINER_DRIVER_ROOT to DRIVER_ROOT_CTR_PATH #211
base: main
Are you sure you want to change the base?
replace CONTAINER_DRIVER_ROOT to DRIVER_ROOT_CTR_PATH #211
Conversation
I believe you will also need to change this in the helm chart |
This env is not currently being set in the helm chart. k8s-dra-driver/deployments/helm/k8s-dra-driver/templates/kubeletplugin.yaml Lines 71 to 93 in 6c34f5f
|
we can add this env to helm chart if need. |
3ebd09f
to
d5d906a
Compare
I don't think that we should be setting this in the helm chart as part of this change. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we should be setting this in the helm chart as part of this change. The /driver-root is an internal path and was not configurable before. If we decide that it should be user definable, let's do that as a follow-up.
Sorry for the back and forth on this @lengrongfu
Signed-off-by: rongfu.leng <[email protected]>
It's all good, happy to help! please take a look. @elezar |
d5d906a
to
178a715
Compare
Fixes: #209