Remove CLIENT_GEN_VERSION and CONTROLLER_GEN_VERSION from devel image #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. I don't think we necessarily need to remove these tools from this Dockerfile. If we know a specific pinned version of these tools works across all of our projects for a given golang version, then we should perfer to pull in this image. If this image doesn't work for a specific repo, it should have a fallback to be able to build a local image until a suitable image can be created here. |
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to leave each repo to set CLIENT_GEN_VERSION and CONTROLLER_GEN_VERSION and simply use
k8s-test-infraas a base image