add controller-gen and client-gen versions to 1.22 builds #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @foolusion thanks for the contribution, could you follow https://docs.pi-hole.net/guides/github/how-to-signoff/ to signoff your commit so the DCO check passes? |
ArangoGutierrez
requested changes
Apr 5, 2024
.github/workflows/image.yaml
Outdated
| @@ -91,4 +98,6 @@ jobs: | |||
| platforms: ${{ env.IMAGE_PLATFORMS }} | |||
| build-args: | | |||
| GOLANG_VERSION=${{ matrix.go-version }} | |||
| CONTROLLER_GEN_VERSION=${{ matrix.controller-gen-version || "v0.9.2" }} | |||
There was a problem hiding this comment.
The workflow is not valid. .github/workflows/image.yaml (Line: 99, Col: 23): Unexpected symbol: '"v0'. Located at position 34 within expression: matrix.controller-gen-version || "v0.9.2"
There was a problem hiding this comment.
Thanks, looks like you have to use single quotes inside the expressions.
This should add the proper controller-gen and client-gen versions to build with go 1.22. I'm not very familiar with github actions so let me know if there is a better way to include the defaults. Signed-off-by: Andrew O'Neill <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> Signed-off-by: Andrew O'Neill <[email protected]>
foolusion
force-pushed
the
add-controller-gen-version
branch
from
a176607 to
764f2a8
Compare
Signed-off-by: Andrew O'Neill <[email protected]>
foolusion
force-pushed
the
add-controller-gen-version
branch
from
53a88b6 to
0dce9a6
Compare
ArangoGutierrez
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add the proper controller-gen and client-gen versions to build with go 1.22. I'm not very familiar with github actions so let me know if there is a better way to include the defaults.