This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Draft: Document asynchronous threads #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniellustig for review. |
miscco
approved these changes
Feb 21, 2023
|
Let’s wait for Dan’s feedback since I’m not sure at all about this one. Just opened a new PR because the old one got quite out of sync with respect to the latest changes in the repo.
…________________________________
From: Michael Schellenberger Costa ***@***.***>
Sent: Tuesday, February 21, 2023 11:53:04 AM
To: NVIDIA/libcudacxx ***@***.***>
Cc: Gonzalo Brito ***@***.***>; Author ***@***.***>
Subject: Re: [NVIDIA/libcudacxx] Document asynchronous threads (PR #371)
@miscco approved this pull request.
—
Reply to this email directly, view it on GitHub<#371 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APQD346SCWXMT27SJVJVVZDWYSNBBANCNFSM6AAAAAAVC3TJL4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
-----------------------------------------------------------------------------------
NVIDIA GmbH
Wuerselen
Amtsgericht Aachen
HRB 8361
Managing Directors: Michael Ching, Donald Robertson, Rebecca Peters and Ludwig von Reiche
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
|
|
Added one minor comment, otherwise LGTM |
gonzalobg
commented
Jul 19, 2023
|
Ready to merge @daniellustig |
|
Initiation of an async-operation (memcpy_async) is not required to spawn a new async-thread. It synchronizes-with an async-thread (could spawn) which is responsible for eventual completion of the async-operation. |
miscco
approved these changes
Jul 24, 2023
gonzalobg
changed the title
|
Making it a draft for the time being. |
|
Could you also please reopen this against the cccl repo? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.