fix install script #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfhammill
pushed a commit
to cfhammill/mig-parted
that referenced
this pull request
Oct 31, 2023
cfhammill
added a commit
to cfhammill/mig-parted
that referenced
this pull request
Nov 1, 2023
The docker instructions as written do not work, but using the pure go example below I noticed it was just missing a path element. This seems to fix it for me. fix golang image version and bin mv bump go version as in NVIDIA#25 use docker bin instead of likely undefined env var Signed-off-by: Chris Hammill <[email protected]>
cfhammill
added a commit
to cfhammill/mig-parted
that referenced
this pull request
Nov 1, 2023
The docker instructions as written do not work, but using the pure go example below I noticed it was just missing a path element. This seems to fix it for me. fix golang image version and bin mv bump go version as in NVIDIA#25 use docker bin instead of likely undefined env var remove the container after completion (--rm) Signed-off-by: Chris Hammill <[email protected]>
|
Hi @colobas please could you rebase this and Sign-off your commit. Ideally you would also create an MR against https://gitlab.com/nvidia/cloud-native/mig-parted isntead, but I can do so if required. |
|
Thanks @colobas. Could you also sign-off your commit? (running |
Signed-off-by: Guilherme Pires <[email protected]>
|
Done. (On gitlab as well) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix install script based on replies to issue #23