Skip to content

Commit

Permalink
Fix docker install instructions
Browse files Browse the repository at this point in the history
The docker instructions as written do not work, but using the pure go example below I noticed it was just missing a path element. This seems to fix it for me.

fix golang image version and bin mv

bump go version as in NVIDIA#25

use docker bin instead of likely undefined env var

remove the container after completion (--rm)

Signed-off-by: Chris Hammill <[email protected]>
  • Loading branch information
cfhammill committed Nov 1, 2023
1 parent 3963759 commit 4b99975
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,13 @@ To build from source, please follow one of the methods below.

#### Use `docker` with `go install`:
```
${DOCKER} run \
docker run \
--rm \
-v $(pwd):/dest \
golang:1.16.4 \
golang:1.20.1 \
sh -c "
go install github.com/NVIDIA/mig-parted/cmd@latest
mv /go/bin/cmd /dest/nvidia-mig-parted
go install github.com/NVIDIA/mig-parted/cmd/nvidia-mig-parted@latest
mv /go/bin/nvidia-mig-parted /dest/nvidia-mig-parted
"
```

Expand Down

0 comments on commit 4b99975

Please sign in to comment.