Add arm64 packages #104
Merged
Add arm64 packages #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
add-arm64-packages
branch
from
96cea10
to
5efdb64
Compare
cdesiniotis
reviewed
Aug 1, 2024
|
|
||
| $(VALID_TARGETS): %: | ||
| @echo "Building for $(TARGET_PLATFORM)" | ||
| docker pull --platform=linux/$(ARCH) $(BASE_IMAGE) |
There was a problem hiding this comment.
Question -- is pulling the base image beforehand required?
There was a problem hiding this comment.
The key here is that we pull the platform-specific image to ensure that this is available when running the build / run commands below. It could be that this is no longer required for newer docker versions, but we still use it for the contianer toolkit where we build multi-arch packages.
cdesiniotis
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.