Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new nvidia-gpu-services.target to ensure proper startup order #105

Merged

Conversation

KeithMnemonic
Copy link
Contributor

This PR adds a new systemd target to ensure the proper startup order for nvidia-mig-manager. The current settings cause a cyclical dependency on systemd-resolved. This results in broken name resolution after the system is rebooted. The systemd-resolved service needs to be manually restarted for name resolution to work properly.

2024-04-22T17:39:34.983435-07:00 ubuntu kernel: systemd[1]: sysinit.target: Found ordering cycle on systemd-resolved.service/start
2024-04-22T17:39:34.983437-07:00 ubuntu kernel: systemd[1]: sysinit.target: Found dependency on nvidia-mig-manager.service/start
2024-04-22T17:39:34.983429-07:00 ubuntu sbkeysync[8851]:      from /usr/share/secureboot/updates/dbx/dbxupdate_x64.bin
2024-04-22T17:39:34.983444-07:00 ubuntu kernel: systemd[1]: sysinit.target: Found dependency on sysinit.target/start
2024-04-22T17:39:34.983443-07:00 ubuntu sbkeysync[8851]:     7fddfe06c44dc4302da54577353c18fdbe11b41cb3e6064ec1c116ee102fe080
2024-04-22T17:39:34.983464-07:00 ubuntu kernel: systemd[1]: sysinit.target: Job systemd-resolved.service/start deleted to break ordering cycle starting with sysinit.target/start

@KeithMnemonic
Copy link
Contributor Author

@klueska Can you please assign some reviewers to this? I do not seem to have the correct permissions.

@klueska
Copy link
Contributor

klueska commented Aug 12, 2024

Is this still up to date based on the latest internal discussions?

@KeithMnemonic KeithMnemonic force-pushed the update_systemd_service_dependency branch 3 times, most recently from fec6679 to ac269f9 Compare August 12, 2024 14:14
@KeithMnemonic KeithMnemonic force-pushed the update_systemd_service_dependency branch from ac269f9 to 3f9e54b Compare August 13, 2024 12:16
@klueska
Copy link
Contributor

klueska commented Aug 13, 2024

Fixes: #103

@KeithMnemonic KeithMnemonic force-pushed the update_systemd_service_dependency branch from 3f9e54b to 51e2a45 Compare August 13, 2024 12:43
Copy link
Contributor

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on the round of reviews. Looks good now.

@klueska
Copy link
Contributor

klueska commented Aug 13, 2024

Ah, one caveat -- we can't merget this unless you sign your commit with:

Signed-off-by: Author Name <[email protected]>

@KeithMnemonic KeithMnemonic force-pushed the update_systemd_service_dependency branch from 51e2a45 to de09fc9 Compare August 13, 2024 13:44
@KeithMnemonic KeithMnemonic force-pushed the update_systemd_service_dependency branch from de09fc9 to 98bc2a5 Compare August 13, 2024 13:48
@klueska klueska merged commit e16f06f into NVIDIA:main Aug 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants